Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] no-deprecated: false positive on commonjs import in no-deprecated rule #3614

Merged
merged 1 commit into from
Aug 5, 2023
Merged

[Fix] no-deprecated: false positive on commonjs import in no-deprecated rule #3614

merged 1 commit into from
Aug 5, 2023

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Aug 5, 2023 •
edited
Loading

Fixes #3606

@codecov
Copy link

codecov bot commented Aug 5, 2023 •
edited
Loading

Codecov Report

Merging #3614 (d73cd51) into master (0667fb0) will increase coverage by 0.00%.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master    #3614   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         132      132           
  Lines        9290     9298    +8     
  Branches     3395     3400    +5     
=======================================
+ Hits         9070     9078    +8     
  Misses        220      220
Files Changed Coverage Δ
lib/rules/no-deprecated.js 99.09% <91.66%> (+0.06%) ⬆️

ljharb
ljharb approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! i ended up combining the check with the previous iteration.

@ljharb ljharb force-pushed the akul/fix-no-deprecated-false-positive branch 2 times, most recently from e76ade4 to d73cd51 Compare August 5, 2023 10:37
@ljharb ljharb merged commit d73cd51 into jsx-eslint:master Aug 5, 2023
290 of 291 checks passed
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request May 24, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
Open
@mjperrins mjperrins mentioned this pull request May 30, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Jun 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jun 3, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jun 3, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jun 3, 2024
Open
This was referenced Jun 3, 2024
Open
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jun 4, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 5, 2024
Open
@cezaraugusto cezaraugusto mentioned this pull request Jun 6, 2024
Merged
@paaschdigital paaschdigital mentioned this pull request Jun 7, 2024
Open
@MANAALHARBI MANAALHARBI mentioned this pull request Jun 8, 2024
Merged
@richyhoopd richyhoopd mentioned this pull request Jun 18, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 18, 2024
Open
This was referenced Jun 18, 2024
Open
Open
Open
Open
This was referenced Sep 25, 2024
Open
Open
@scatools-demo scatools-demo mentioned this pull request Sep 25, 2024
Open
This was referenced Sep 25, 2024
Open
Open
@DadonStyle DadonStyle mentioned this pull request Sep 26, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Sep 26, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Sep 27, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Sep 27, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Sep 28, 2024
Open
This was referenced Sep 28, 2024
Open
Open
Open
@DadonStyle DadonStyle mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Open
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Oct 3, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 3, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 3, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 3, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 3, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: false positive on commonjs imports for no-deprecated
2 participants
@akulsr0 @ljharb